pkp/pkp-lib#10671 Review Report plugin compatibility and test for 3.5.0 #55
Conversation
|
@asmecher can you please review this PR , as per my check it works fine with latest main of OJS and OMP . This PR does not fix anything but just do some general cleanup and added some type hints . |
| @@ -150,7 +148,7 @@ public function display($args, $request) | |||
| /** @var ReviewFormElementDAO */ | |||
| $reviewFormElementDao = DAORegistry::getDAO('ReviewFormElementDAO'); | |||
|
|
|||
| foreach ($reviewsIterator as $row) { | |||
| foreach ($reviewsIterator as $row) { /** @var stdClass $row */ | |||
| if (substr($row->date_response_due, 11) === '00:00:00') { | |||
There was a problem hiding this comment.
Probably out of scope, but there are some proposals for improvements to date handling over here. Long story short: as much as possible, we should use objects for date representations (and Laravel makes this easy by getting them right from the database that way). This probably still works, but it's risky because it assumes a lot about the date formats.
There was a problem hiding this comment.
Thats right , but our review related table still hasn't been converted to Eloquent model and using DB call will also return simple object so we will not get carbon instances for those yet . However we can convert it to carbon to make it work. Should we do it here or later when we moved to Eloquent for review related tables ?
for pkp/pkp-lib#10671